Runtime CR examples updated #345
Conversation
kyma-bot
added
cla: yes
kyma-bot
added
area/documentation
kyma-bot
added
size/L
akgalwas
changed the title
| # spec.shoot.purpose is required | ||
| purpose: evaluation | ||
| # spec.shoot.region is required | ||
| region: eu-central-1 | ||
| region: polandcentral |
There was a problem hiding this comment.
what was your intention with this change?
| # spec.shoot.worker.zones is required | ||
| zones: | ||
| - 1 | ||
| - "1" |
There was a problem hiding this comment.
Why is this quotation necessary?
There was a problem hiding this comment.
Also, couldn't we use the actual regions here to omit the number of things someone has to change in the CR to make it work? We have such zones listed in e.g. aws-trial example
There was a problem hiding this comment.
Why is this quotation necessary?
When quotation is missed we will get the following error:
The Runtime "azure-lite" is invalid: spec.shoot.provider.workers[0].zones[0]: Invalid value: "integer": spec.shoot.provider.workers[0].zones[0] in body must be of type string: "integer"
Kubernetes expects string field, as zones have the following definition in the CRD:
zones:
description: |-
Zones is a list of availability zones that are used to evenly distribute this worker pool. Optional as not every provider may support availability zones.
items:
type: string
type: array
There was a problem hiding this comment.
Also, couldn't we use the actual regions here to omit the number of things someone has to change in the CR to make it work? We have such zones listed in e.g. aws-trial example
We do use actual regions. polandcentral was introduced in the last year and is fully supported by Gardener.
| namespace: kcp-system | ||
| spec: | ||
| shoot: | ||
| # spec.shoot.name is required | ||
| name: shoot-name | ||
| name: azure-lite |
There was a problem hiding this comment.
usernameClaim: sub at line 40 has incorrect indentation and can't be applied.
There was a problem hiding this comment.
usernameClaim: subat line 40 has incorrect indentation and can't be applied.
Fixed
|
I've managed to test succesfully the examples for
|
The following yamls : |
Description
Changes proposed in this pull request:
Related issue(s)
#332