Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default machine image name #382

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Sep 16, 2024

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

#343

@VOID404 VOID404 requested a review from a team as a code owner September 16, 2024 07:43
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2024
@Disper Disper requested a review from akgalwas September 17, 2024 07:46
@Disper
Copy link
Member

Disper commented Sep 17, 2024

Config in MPC should be merged first
/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 17, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 17, 2024
akgalwas
akgalwas previously approved these changes Sep 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 19, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 19, 2024
akgalwas
akgalwas previously approved these changes Sep 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 19, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 19, 2024
@akgalwas akgalwas merged commit 26f8316 into kyma-project:main Sep 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants