Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dump shoot name #385

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Fix dump shoot name #385

merged 6 commits into from
Sep 20, 2024

Conversation

akgalwas
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix for storing shoot spec, and runtime CR in dry run mode
  • Refactoring to reuse sFnDumpShootSpec state

Related issue(s)
#343

@akgalwas akgalwas requested a review from a team as a code owner September 17, 2024 10:51
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2024
m00g3n
m00g3n approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 20, 2024
@akgalwas akgalwas merged commit 2f98520 into kyma-project:main Sep 20, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akgalwas @m00g3n @kyma-bot