Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding metrics for Runtime CR state #403

Merged
merged 34 commits into from
Oct 21, 2024
Merged

Adding metrics for Runtime CR state #403

merged 34 commits into from
Oct 21, 2024

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Sep 30, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Following metrics collected:
    • Runtime states as they are updated during sFnUpdateStatus() function
    • Unexpected stops of FSM when the machine stops before finishing processing with one of following functions :
      • stop()
      • updateStatusAndStopWithError()
  • Providing metrics with Mock objects
  • Refactoring of Audit log objects, wich will not be created each time when state machine is created (multiple times per reconclitiaon)
  • Runtime Reconciler is configured with duration of the reconcile. Will allow to shorten integration tests
  • Adapting unit tests and integration tests

Related issue(s)

@koala7659 koala7659 requested a review from a team as a code owner September 30, 2024 14:18
@koala7659 koala7659 marked this pull request as draft September 30, 2024 14:18
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2024
@koala7659 koala7659 marked this pull request as ready for review October 11, 2024 07:35
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
m00g3n
m00g3n previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 21, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@m00g3n m00g3n added the lgtm Looks good to me! label Oct 21, 2024
m00g3n
m00g3n approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot merged commit 7ad2c69 into kyma-project:main Oct 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koala7659 @kyma-bot @m00g3n