Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shoot matcher #418

Merged
merged 14 commits into from
Oct 18, 2024
Merged

Fix shoot matcher #418

merged 14 commits into from
Oct 18, 2024

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Oct 14, 2024

Description

Changes proposed in this pull request:

  • shoot matcher fixed to cover converter's subset of properties

  • metadata/

    • annotations
    • labels

  • spec

    • maintenance
      • autoUpdate
        • kubernetesVersion
        • machineImageVersion
    • tolerations/
    • cloudProfile
      • name
    • extensions (dnsExtension, networkFilter, certServiceExtension)
    • dns
      • domain
      • providers/
        • domains/
          • include
        • primary
        • secretName
        • type
    • provider/
      • type
      • workers /
        • providerConfig
        • machine
          • image
            • name
            • version
      • infrastructureConfig
      • controlPlaneConfig
    • kubernetes
      • version
      • enableStaticTokenKubeconfig
      • kubeAPIServer
        • oidcConfig
          • caBundle
          • clientID
          • groupsClaim
          • groupsPrefix
          • issuerURL
          • requiredClaims
          • signingAlgs
          • usernameClaim
          • usernamePrefix
    • purpose
    • region
    • secretBindingName
    • networking/
      • type
      • nodes
      • pods
      • services
    • controlPlane

Related issue(s)

See also: #342

@m00g3n m00g3n requested a review from a team as a code owner October 14, 2024 16:53
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 14, 2024
akgalwas
akgalwas requested changes Oct 15, 2024
View reviewed changes
hack/shoot-comparator/pkg/shoot/matcher.go Show resolved Hide resolved
hack/shoot-comparator/pkg/shoot/matcher.go Outdated Show resolved Hide resolved
hack/shoot-comparator/pkg/shoot/matcher.go Outdated Show resolved Hide resolved
hack/shoot-comparator/pkg/shoot/matcher.go Outdated Show resolved Hide resolved
hack/shoot-comparator/pkg/shoot/matcher.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2024
@kyma-bot kyma-bot merged commit e7f8174 into kyma-project:main Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akgalwas akgalwas akgalwas approved these changes

Assignees

@akgalwas akgalwas

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m00g3n @akgalwas @kyma-bot