Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrator dependencies updated #425

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Migrator dependencies updated #425

merged 11 commits into from
Oct 28, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Oct 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Runtime migrator dependencies bumped
  • spec.provider.worker field rewritten directly
  • Dependency to local sources added
  • Fixed storing runtime CR yaml in dry run mode when differences were detected
  • Fixes in the matchers:
    • label matchers problem fixed
    • ignoring StructuredAuthentication field
    • Comparing raw extension with RawExtensionMatcher.

Related issue(s)
#400

@akgalwas akgalwas requested a review from a team as a code owner October 21, 2024 16:54
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@akgalwas akgalwas mentioned this pull request Oct 23, 2024
Closed
1 task
m00g3n
m00g3n approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 28, 2024
@kyma-bot kyma-bot merged commit a1ff058 into kyma-project:main Oct 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akgalwas @m00g3n @kyma-bot