Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fixes in the migrator #474

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

akgalwas
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Migrator output made shorter
  • Fixed issue in report
  • Documentation added

Related issue(s)
#400

@akgalwas akgalwas requested a review from a team as a code owner October 31, 2024 14:23
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
@akgalwas akgalwas requested a review from a team as a code owner October 31, 2024 14:29
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
@akgalwas akgalwas changed the title Fixed problem with incorrect path to CR file plus output made shorter Final fixes in the migrator Oct 31, 2024
@mvshao mvshao requested a review from m00g3n November 5, 2024 08:46
hack/runtime-migrator/README.md Outdated Show resolved Hide resolved
hack/runtime-migrator/README.md Outdated Show resolved Hide resolved
hack/runtime-migrator/README.md Outdated Show resolved Hide resolved
hack/runtime-migrator/README.md Outdated Show resolved Hide resolved
hack/runtime-migrator/README.md Outdated Show resolved Hide resolved
m00g3n
m00g3n previously approved these changes Nov 5, 2024
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 5, 2024
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 5, 2024
@kyma-bot kyma-bot merged commit 5c33923 into kyma-project:main Nov 5, 2024
10 checks passed
@akgalwas akgalwas deleted the migrator-final-changes branch November 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants