-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auditlogs switch impl #477
Fix auditlogs switch impl #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
internal/controller/runtime/fsm/runtime_fsm_apply_clusterrolebindings.go
Outdated
Show resolved
Hide resolved
5495d5b
to
f5e2730
Compare
5b19110
to
2ec2608
Compare
b428654
to
157179c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
pkg/gardener/shoot/extender/auditlogs/auditlogs_configuration.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
pkg/gardener/shoot/extender/auditlogs/auditlogs_configuration.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
…un.go Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
bcaf88d
to
f60d316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Changes proposed in this pull request:
Related issue(s)