Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auditlogs switch impl #477

Merged
merged 18 commits into from
Nov 12, 2024
Merged

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Nov 4, 2024

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

@m00g3n m00g3n requested a review from a team as a code owner November 4, 2024 13:24
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

cmd/main.go Outdated Show resolved Hide resolved
@m00g3n m00g3n force-pushed the fix-auditlogs-switch-impl branch from 5495d5b to f5e2730 Compare November 7, 2024 14:12
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2024
@m00g3n m00g3n force-pushed the fix-auditlogs-switch-impl branch from 5b19110 to 2ec2608 Compare November 7, 2024 15:38
@m00g3n m00g3n force-pushed the fix-auditlogs-switch-impl branch from b428654 to 157179c Compare November 9, 2024 12:13
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

m00g3n and others added 2 commits November 12, 2024 12:35
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

m00g3n and others added 2 commits November 12, 2024 13:22
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

…un.go

Co-authored-by: Przemyslaw Golicz <przemyslaw.golicz@sap.com>
@m00g3n m00g3n force-pushed the fix-auditlogs-switch-impl branch from bcaf88d to f60d316 Compare November 12, 2024 12:54
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 12, 2024
@kyma-bot kyma-bot merged commit a7fdf24 into kyma-project:main Nov 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants