Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new extender to enforce configuration of shoot seed within the same region as the shoot #488

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Nov 15, 2024

Implementation

When EnforceSeedLocation flag is enabled in Runtime CR
Setting Shoot seedSelector.matchLabels field to the value

seed.gardener.cloud/region : <Shoot region>

Related issue(s)
#241
kyma-project/kyma#18182

Additional info
There are some cases for HA dedicated seeds - please make sure this solution will work in case of HA clusters

kyma-project/kyma#18182 (comment)

@koala7659 koala7659 requested a review from a team as a code owner November 15, 2024 13:33
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Nov 15, 2024
@koala7659 koala7659 changed the title WIP Add new extender to enforce configuration of shoot seed within the sa… WIP Add new extender to enforce configuration of shoot seed within the same region as the shoot Nov 15, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2024
@koala7659 koala7659 requested a review from tobiscr November 18, 2024 10:36
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2024
tobiscr
tobiscr previously approved these changes Nov 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 19, 2024
@koala7659 koala7659 changed the title WIP Add new extender to enforce configuration of shoot seed within the same region as the shoot Add new extender to enforce configuration of shoot seed within the same region as the shoot Nov 20, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 20, 2024
@tobiscr tobiscr self-requested a review November 20, 2024 13:37
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2024
@kyma-bot kyma-bot merged commit 71cc46f into kyma-project:main Nov 20, 2024
9 checks passed
@tobiscr
Copy link
Contributor

tobiscr commented Nov 21, 2024

Added #511 to add missing check of lastOperation message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants