generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new extender to enforce configuration of shoot seed within the same region as the shoot #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me region as the shoot
kyma-bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cla: yes
Indicates the PR's author has signed the CLA.
labels
Nov 15, 2024
koala7659
changed the title
WIP Add new extender to enforce configuration of shoot seed within the sa…
WIP Add new extender to enforce configuration of shoot seed within the same region as the shoot
Nov 15, 2024
kyma-bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 15, 2024
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Nov 18, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 18, 2024
tobiscr
previously approved these changes
Nov 19, 2024
koala7659
changed the title
WIP Add new extender to enforce configuration of shoot seed within the same region as the shoot
Add new extender to enforce configuration of shoot seed within the same region as the shoot
Nov 20, 2024
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 20, 2024
tobiscr
approved these changes
Nov 20, 2024
Added #511 to add missing check of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
When EnforceSeedLocation flag is enabled in Runtime CR
Setting Shoot
seedSelector.matchLabels
field to the valueseed.gardener.cloud/region : <Shoot region>
Related issue(s)
#241
kyma-project/kyma#18182
Additional info
There are some cases for HA dedicated seeds - please make sure this solution will work in case of HA clusters
kyma-project/kyma#18182 (comment)