Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer deletes crbs managed by reconciler #499

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

Disper
Copy link
Member

@Disper Disper commented Nov 21, 2024

Description

Changes proposed in this pull request:

  • ClusterRoleBindings with label "reconciler.kyma-project.io/managed-by": "reconciler" are no longer deleted.
  • label "app": "kyma", is no longer taken into account

Related issue(s)
fixes #490

@Disper Disper requested a review from a team as a code owner November 21, 2024 06:46
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 21, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 21, 2024
@Disper Disper enabled auto-merge November 21, 2024 13:11
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 21, 2024
@kyma-bot kyma-bot merged commit 783dc2c into kyma-project:main Nov 21, 2024
9 checks passed
@Disper Disper deleted the crb_proper_recreation branch November 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KIM should not delete ClusterRoleBindings created manually
3 participants