Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configures dependabot for runtime-migrator app #500

Merged
merged 3 commits into from
Nov 21, 2024
Merged

configures dependabot for runtime-migrator app #500

merged 3 commits into from
Nov 21, 2024

Conversation

Disper
Copy link
Member

@Disper Disper commented Nov 21, 2024 •
edited
Loading

Description

Dependabot PRs are often failing on the unit test github action with error.

Error: load packages in root "/home/runner/work/infrastructure-manager/infrastructure-manager/hack/runtime-migrator": err: exit status 1: stderr: go: updates to go.mod needed; to update it:
	go mod tidy

Related documentation

Changes proposed in this pull request:

  • adds to dependabot's configuration location of runtime-migrator hoping that it will cause it to run go mod tidy in the migrator directory.
  • ...
  • ...

Related issue(s)

@Disper Disper requested a review from a team as a code owner November 21, 2024 07:25
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2024
@Disper Disper enabled auto-merge November 21, 2024 07:38
VOID404
VOID404 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@VOID404 VOID404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, groups might be an option related to this too?
but this looks like directories is in fact the solution

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 21, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 21, 2024
@kyma-bot kyma-bot merged commit 8cada94 into kyma-project:main Nov 21, 2024
9 checks passed
@Disper Disper deleted the dependabot_migrator branch November 21, 2024 08:08
@Disper Disper mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOID404 VOID404 VOID404 approved these changes

Assignees

@VOID404 VOID404

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @VOID404 @kyma-bot