generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrator: added fetching shoot to minimise runtime recreation risk #522
Merged
kyma-bot
merged 8 commits into
kyma-project:main
from
akgalwas:migrator-prevent-runtime-recreation
Nov 26, 2024
Merged
Migrator: added fetching shoot to minimise runtime recreation risk #522
kyma-bot
merged 8 commits into
kyma-project:main
from
akgalwas:migrator-prevent-runtime-recreation
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 22, 2024
akgalwas
changed the title
Fix in the comparison, and added fetching shoot to minimize runtime r…
Migrator: added fetching shoot to minimise runtime recreation risk
Nov 22, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 23, 2024
m00g3n
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 26, 2024
m00g3n
previously approved these changes
Nov 26, 2024
grego952
approved these changes
Nov 26, 2024
m00g3n
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
akgalwas
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the migration process users may delete runtimes. There is the following scenario:
It is depicted on the following diagram:
There are two possible solutions to this problem:
shoot
, andruntimeID
pair as inputThe second option is easier to implement, and requires less changes in documentation. In addition we should check if the deletion is in progress.
Changes proposed in this pull request: