Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing way extensions are handled in KIM and matchers #535

Merged
merged 51 commits into from
Dec 4, 2024
Merged

Changing way extensions are handled in KIM and matchers #535

merged 51 commits into from
Dec 4, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Nov 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix for overwriting DNS during upgrade
  • Fix for overwriting OIDC during upgrade
  • Fix for matchers to detect unwanted updates of the extension list
  • DNS extender no longer sets reference to dns credentials secret
  • spec.resources is taken into account during the comparison.

Related issue(s)
#533

@akgalwas akgalwas requested a review from a team as a code owner November 28, 2024 10:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@akgalwas akgalwas changed the title Added extender taking DNS config from the shoot Changing way extensions are handled in KIM and matchers Nov 28, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 3, 2024
m00g3n
m00g3n approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 4, 2024
@kyma-bot kyma-bot merged commit bf2df62 into kyma-project:main Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akgalwas @m00g3n @kyma-bot @koala7659 @Disper