Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handing missing Disabled field in OIDC extension data to avoid crash #551

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Dec 5, 2024

Handling exception case for Patch operation when Disabled field is missing from OIDC extension data in the shoot like following:

  extensions:
    - type: shoot-oidc-service
    - type: shoot-dns-service

In the old implementation the missing Disabled field was causing unexpected crash.

In the new implementation the missing Disabled filed is interpreted as "Enabled by default"

@koala7659 koala7659 requested a review from a team as a code owner December 5, 2024 11:29
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 5, 2024
@Disper Disper enabled auto-merge December 5, 2024 11:36
@kyma-bot kyma-bot merged commit d1681db into kyma-project:main Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants