Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kim should not delete existing cluster role binding with subject of type service accounts #554

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Kim should not delete existing cluster role binding with subject of type service accounts #554

merged 2 commits into from
Dec 5, 2024

Conversation

Disper
Copy link
Member

@Disper Disper commented Dec 5, 2024 •
edited by koala7659
Loading

Description

Changes proposed in this pull request:

  • Kim should not delete existing cluster role binding with subject of type service accounts
  • ...
  • ...

Related issue(s)

@Disper Disper requested a review from a team as a code owner December 5, 2024 15:06
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 5, 2024
@Disper Disper marked this pull request as draft December 5, 2024 15:06
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@Disper Disper changed the title Kim should filter out service accounts from deletion Kim should not delete existing service accounts Dec 5, 2024
@Disper Disper marked this pull request as ready for review December 5, 2024 15:31
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@Disper Disper enabled auto-merge December 5, 2024 15:59
koala7659
koala7659 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 5, 2024
@kyma-bot kyma-bot merged commit 0172347 into kyma-project:main Dec 5, 2024
9 checks passed
@koala7659 koala7659 changed the title Kim should not delete existing service accounts Kim should not delete existing cluster role binding with subject of type service accounts Dec 5, 2024
@Disper Disper deleted the do_not_delete_service_accounts branch December 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @koala7659 @kyma-bot