Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIM Migrator - RBAC migration code updates #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Dec 11, 2024

During migration of CRBs we have taken all subjects from CRBs labeled with reconciler.kyma-project.io/managed-by=reconciler,app=kyma and turned them into CRB with subject of User type type with cluster-admin access.

  • We did not check if they were previously cluster-admins or not.
  • We did not if they were previously kind of User type (edited)

Code changes:

  • Add filtering for to migrate only Cluster Role Bindings of cluster-admins access level.
  • Add filtering for to migrate only Cluster Role Bindings with subject of User type.
  • Enhance the migration logic to add an deprecation-label to each CRB with that will be migrated: kyma-project.io/deprecation: this ClusterRoleBinding is deprecated and will be removed in next days!

Relates issue:
#556

@koala7659 koala7659 requested a review from a team as a code owner December 11, 2024 17:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@koala7659 koala7659 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@koala7659 koala7659 changed the title RBAC Migration code updates KIM Migrator - RBAC migration code updates Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants