-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #22 reuse folder has incorrect name #60
Fix #22 reuse folder has incorrect name #60
Conversation
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @dellagustin-sap. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The repository was not REUSE compliant becauce the name of the `.reuse` folder was incorrect. This was fixed by renaming it. Related issues: - kyma-project#22
de9f17b
to
58a755e
Compare
/check-cla |
Hi @dellagustin-sap, I've kicked the jobs to run and I see that the unit tests have failed, but it's highly unlikely that this PR has caused the error. We will investigate that. |
Update: I've confirmed that "Gardener Cluster controller"."Secret with kubeconfig exists"."Force rotation" test is flaky. |
Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request. You can edit the title by writing /retitle in a comment.
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Flaky tests were fixed in #63 |
Description
Changes proposed in this pull request:
reuse
folder to fix REUSE compliance (https://api.reuse.software/info/github.com/kyma-project/infrastructure-manager)Related issue(s)
Fixes #22
Tested with docker, command:
docker run --rm --volume $(pwd):/data fsfe/reuse lint