Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22 reuse folder has incorrect name #60

Merged

Conversation

dellagustin-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

Related issue(s)

Fixes #22

Tested with docker, command: docker run --rm --volume $(pwd):/data fsfe/reuse lint

@dellagustin-sap dellagustin-sap requested a review from a team as a code owner November 9, 2023 16:37
@kyma-bot kyma-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 9, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 9, 2023

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 9, 2023

Hi @dellagustin-sap. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
The repository was not REUSE compliant becauce the name of the `.reuse`
folder was incorrect.

This was fixed by renaming it.

Related issues:
- kyma-project#22
@dellagustin-sap dellagustin-sap force-pushed the fix#22__reuse-folder-name-incorrect branch from de9f17b to 58a755e Compare November 9, 2023 16:39
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

@dellagustin-sap
Copy link
Contributor Author

dellagustin-sap commented Nov 9, 2023

I tried signing the CLA, but there seems to be a problem.
I get the screen below but cannot get past it:
image

Update: Retried and it worked.

@dellagustin-sap
Copy link
Contributor Author

/check-cla

@Disper
Copy link
Member

Disper commented Nov 13, 2023

Hi @dellagustin-sap,
thank you for your PR ❤️!

I've kicked the jobs to run and I see that the unit tests have failed, but it's highly unlikely that this PR has caused the error. We will investigate that.

@Disper Disper self-assigned this Nov 13, 2023
@Disper
Copy link
Member

Disper commented Nov 13, 2023

Update: I've confirmed that "Gardener Cluster controller"."Secret with kubeconfig exists"."Force rotation" test is flaky.

@kyma-bot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@Disper Disper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/meow

@kyma-bot
Copy link
Contributor

@Disper: cat image

In response to this:

LGTM
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2023
@Disper
Copy link
Member

Disper commented Nov 13, 2023

Flaky tests were fixed in #63

@m00g3n m00g3n removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 13, 2023
@kyma-bot kyma-bot merged commit 932ccc8 into kyma-project:main Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rl-reuse_tool-4] Violation against OSS Rules of Play
5 participants