Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GardenerCluster CRD printed columns #68

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Nov 17, 2023

Description

Update GardenerCluster CRD printed columns to show information about CR state, runtime-id and shoot-name.
E.g.

$ kubectl get gardenerclusters.infrastructuremanager.kyma-project.io -A
NAMESPACE    NAME         STATE   RUNTIME-ID   SHOOT-NAME   AGE
kcp-system   runtime-id   Ready   runtime-id   shoot-name   2m40s

Changes proposed in this pull request:

  • STATE and RUNTIME-ID columns added

@m00g3n m00g3n requested a review from a team as a code owner November 17, 2023 15:45
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2023
Copy link
Member

@Disper Disper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also the AGE field and kyma-project.io/shoot-name

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2023
@kyma-bot kyma-bot merged commit 2a8c0af into kyma-project:main Nov 20, 2023
5 checks passed
@Disper
Copy link
Member

Disper commented Nov 22, 2023

on DEV (that runs on latest d79e85b), I can still see the old way of printing:

[・‿・] ~ kubectl get gardenerclusters -n kcp-system
NAME         AGE
a5c9b4e      171m
bf3485c      4d23h
c-1ef5961    4d23h
c-28b39a2    171m
c-38414f2    171m
c-3acbdd1    4d23h
c-5287766    4d23h
c-61b5087    4d23h
c-67fae28    171m
c-91c8454    171m
c-939e9b0    4d23h
c-97b785b    4d23h
c-9c16d48    4d23h
c-9d85254    4d23h
d3d2dd1      4d23h
runtime-id   45h
[・‿・] ~ kubectl get gardenercluster -n kcp-system a5c9b4e
NAME      AGE
a5c9b4e   171m

@Disper
Copy link
Member

Disper commented Nov 22, 2023

Now it works

kubectl get gardenerclusters -n kcp-system
NAME         STATE   RUNTIME-ID                             SHOOT-NAME   AGE
a5c9b4e      Error   8bb2a83f-68f6-43bd-a34b-11c04f76f32d   a5c9b4e      4h27m
bf3485c      Error   a0a14826-0032-47cc-8946-391164bd222b   bf3485c      5d1h
c-1ef5961    Ready   0acea249-a4e2-4757-947e-37de3bed2cc9   c-1ef5961    5d1h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants