Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete secret #73

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix delete secret #73

merged 1 commit into from
Nov 28, 2023

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Nov 27, 2023

Description

Changes proposed in this pull request:

  • Fix delete secret
  • Update create_secrets benchmark function

@m00g3n m00g3n requested a review from a team as a code owner November 27, 2023 16:08
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2023
Disper
Disper previously approved these changes Nov 28, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 28, 2023
@Disper
Copy link
Member

Disper commented Nov 28, 2023

Will still have to test it on DEV after the image bump

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. and removed lgtm Looks good to me! labels Nov 28, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 28, 2023
@kyma-bot kyma-bot merged commit 65e4ecb into kyma-project:main Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disper Disper Disper approved these changes

Assignees

@Disper Disper

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m00g3n @Disper @kyma-bot