Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] Metrics PoC #89

Merged
merged 11 commits into from
Dec 4, 2023
Merged

[WiP] Metrics PoC #89

merged 11 commits into from
Dec 4, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented Dec 4, 2023

Description

Changes proposed in this pull request:

  • Adds a PoC metrics for the sake of enabling grafana/plutono dashboard configuration
  • ...
  • ...

Related issue(s)
#11

@Disper Disper requested a review from a team as a code owner December 4, 2023 09:36
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Dec 4, 2023
m00g3n
m00g3n approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 4, 2023
@Disper Disper added lgtm Looks good to me! and removed lgtm Looks good to me! do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 4, 2023
@kyma-bot kyma-bot merged commit 89dfec3 into kyma-project:main Dec 4, 2023
6 checks passed
@Disper Disper deleted the metrics branch December 4, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @m00g3n @kyma-bot