Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renames infrastructure manager roles and rolebindings #94

Merged
merged 2 commits into from
Dec 11, 2023
Merged

renames infrastructure manager roles and rolebindings #94

merged 2 commits into from
Dec 11, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented Dec 11, 2023

Description

Changes proposed in this pull request:
renaming of:

  • leader-election-role
  • leader-election-rolebinding
  • manager-role
  • manager-rolebinding

Related issue(s)
#93

@Disper Disper requested a review from a team as a code owner December 11, 2023 08:06
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2023
m00g3n
m00g3n approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2023
@kyma-bot kyma-bot merged commit ad7688f into kyma-project:main Dec 11, 2023
6 checks passed
@Disper Disper deleted the roles_renaming branch December 13, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @m00g3n @kyma-bot