Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove image-syncer amd64Only flag #12417

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Remove image-syncer amd64Only flag #12417

merged 4 commits into from
Dec 9, 2024

Conversation

Sawthis
Copy link
Contributor

@Sawthis Sawthis commented Dec 5, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove image-syncer amd64Only flag
  • Sync the whole index if possible. Otherwise, sync a single image.

Related issue(s)

#11712

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@Sawthis Sawthis self-assigned this Dec 6, 2024
@Sawthis @IwonaLanger
Apply suggestions from code review
5359e88 
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
IwonaLanger
IwonaLanger previously approved these changes Dec 9, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 9, 2024
Sawthis
Sawthis commented Dec 9, 2024
View reviewed changes
cmd/image-syncer/main.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 9, 2024
@Sawthis Sawthis requested a review from IwonaLanger December 9, 2024 12:19
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 9, 2024
@kyma-bot kyma-bot merged commit 6cfc713 into kyma-project:main Dec 9, 2024
34 checks passed
@Sawthis Sawthis assigned Sawthis and unassigned Sawthis and IwonaLanger Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@KacperMalachowski KacperMalachowski KacperMalachowski approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj mmitoraj is a code owner

@NHingerl NHingerl Awaiting requested review from NHingerl NHingerl is a code owner

@grego952 grego952 Awaiting requested review from grego952 grego952 is a code owner

@nataliasitko nataliasitko Awaiting requested review from nataliasitko nataliasitko is a code owner

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@akiioto akiioto Awaiting requested review from akiioto akiioto is a code owner automatically assigned from kyma-project/prow

Assignees

@Sawthis Sawthis

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sawthis @KacperMalachowski @IwonaLanger @kyma-bot