Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Manager Multi-select and Portfolio Actions Preview #631

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

rithvikvibhu
Copy link
Collaborator

@rithvikvibhu rithvikvibhu commented Jun 14, 2023

This is a single PR for 2 features since they are somewhat related. Closes #570, Closes #593.

Domain Manager Multi-select

Multiple domains can be selected with checkboxes.

unselected selected
image image
  • Both search filter and pagination preserve selection, so it's easier to mark domains
  • The previous Bulk Transfer button that brought up a modal is replaced by this multi-select. With the domain selection taking place before the transfer modal, the same domain selection can be used for other actions.
  • Currently, there's Transfer and Renew. Others like "Set Records" can be added similarly.
  • Bulk Finalize is removed from Domain Manager:
    • Portfolio has had a Finalize card which does the exact same thing
    • The warning about ensuring Exchange names being finalized here is moved to the Finalize card preview (the next feature below) - it doesn't just warn, it compares and stops them from being finalized in bulk.

Portfolio Actions Preview

Name related actions (Register, Renew, Transfer, Finalize) now preview when clicking the cards instead of blindly sending.

renew, finalize transferring, register
image image
image image
  • Reveals and Redeems don't get any preview
  • It's also possible to (un)select before confirming
  • This is helpful when the list is > what fits in a batch
  • Checks for possible issues in preview (unregistered names can't be renewed, etc.)

Other changes

  • Bulk Transfer now handles max limits properly
  • After completing a portfolio card, the pending tx shows up in the list without having to switch pages
    • it takes a short time after a tx is sent from a node to make its way to the wallet, so added a delay before refreshing pending transactions
  • In the My Domains table, the "HNS Paid" column incorrectly displayed the highest bid value, not the actual value of the domain (which is the hns paid)

@rithvikvibhu rithvikvibhu added the needs translation PR updates locale strings and have not yet been translated label Jun 14, 2023
@rithvikvibhu rithvikvibhu force-pushed the multiselect-and-bulkconfirm branch from 406d8f1 to 225cc8a Compare June 15, 2023 16:10
@miguelgargallo
Copy link
Contributor

It would be great to index list by date, last 30 tlds to expire, automatically renew or transfer, aka also make a default function, to those in less than X months (user can set up manually, by default 3 monhts)

Comment on lines +18 to +20
if (coin) {
if (!coin)
continue;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found by @Falci

@miguelgargallo
Copy link
Contributor

the "copy" in the red warning is a link that copies text is it not understandable in UI/UX terms, a button of "Copy" in red would be great

@rithvikvibhu rithvikvibhu mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs translation PR updates locale strings and have not yet been translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review names and confirm before submitting bulk actions Multi-select and bulk actions in Domain Manager
2 participants