Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow credit invoices #1

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

ValentinMezev
Copy link
Contributor

@ValentinMezev ValentinMezev commented Dec 19, 2024

The library currently allows only positive amounts to be reported.
This change allows negative amounts to be reported as well to represent a credit to an existing invoice.
Please, let me know if crediting works differently according to the Croatian tax authority system.

@arvvoid arvvoid self-requested a review December 19, 2024 09:56
@arvvoid arvvoid added bug Something isn't working Triage: completed Review completed labels Dec 19, 2024
@arvvoid
Copy link
Member

arvvoid commented Dec 19, 2024

Hello,

You are correct; the previous restriction was an oversight. Invoices should indeed allow for negative values to represent credits. Thank you for pointing this out.

I have updated the CI action configuration. Could you please merge the latest changes from the upstream main branch into your PR? This will ensure that the CI environment variables are correctly applied, allowing the checks to succeed.

Thank you again for your contribution!

As for the Croatian tax authority requirements, at the time of writing, I am certain that crediting invoices using negative values (to represent credit notes or invoice corrections) is both allowed and the standard method of handling such adjustments. This is not legal or tax advice; for official confirmation, please consult a qualified tax advisor or contact the Croatian tax authorities directly.

@ValentinMezev
Copy link
Contributor Author

Hello,

You are correct; the previous restriction was an oversight. Invoices should indeed allow for negative values to represent credits. Thank you for pointing this out.

I have updated the CI action configuration. Could you please merge the latest changes from the upstream main branch into your PR? This will ensure that the CI environment variables are correctly applied, allowing the checks to succeed.

Thank you again for your contribution!

As for the Croatian tax authority requirements, at the time of writing, I am certain that crediting invoices using negative values (to represent credit notes or invoice corrections) is both allowed and the standard method of handling such adjustments. This is not legal or tax advice; for official confirmation, please consult a qualified tax advisor or contact the Croatian tax authorities directly.

Thank you for your response @arvvoid
I rebased and all CI checks are passing. Can you please merge it if you think the change is ok (I don't seem to be allowed to merge the PR).

@arvvoid arvvoid merged commit c6838b6 into l-d-t:main Dec 20, 2024
8 checks passed
@arvvoid
Copy link
Member

arvvoid commented Dec 20, 2024

@ValentinMezev merged, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Triage: completed Review completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants