Skip to content

Commit

Permalink
Unbreak the experimental Kubernetes test in 99-labs/02-webapps
Browse files Browse the repository at this point in the history
  • Loading branch information
rg0now committed Sep 27, 2023
1 parent 42a8145 commit 64f965e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
3 changes: 3 additions & 0 deletions 99-labs/02-webapps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,9 @@ Extend the web app to also return the version of Go used to compile the web serv
> PASS
> ```
> **Note**
> The test is trying its best to build the container image using your Dockerfile and deploy it into Minikube using your manifest, but since there are many moving parts there is a good chance something will go wrong. If the test fails, try to understand what's missing. If it still fails do not worry too much: that's most probably our fault. Just tell us what went wrong and test by hand.
<!-- Local Variables: -->
<!-- mode: markdown; coding: utf-8 -->
<!-- eval: (auto-fill-mode -1) -->
Expand Down
7 changes: 2 additions & 5 deletions 99-labs/code/helloworld/kubernetes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,11 @@
package main

import (
"bytes"
"context"
"errors"
"fmt"
"io"
"log"
"net"
"net/http"
"os/exec"
"regexp"
"strings"
"testing"
Expand All @@ -29,7 +25,8 @@ func TestHelloWorldKubernetes(t *testing.T) {
execCmd(t, "kubectl", "delete", "-f", "deploy/kubernetes-service.yaml")

// build the container image
execCmd(t, "minikube", "image", "build", "-t", "l7mp/helloworld", "-f", "deploy/Dockerfile", ".")
execCmd(t, "minikube", "image", "build", "-t", "helloworld", "-f", "deploy/Dockerfile", ".")
go execCmd(t, "minikube", "tunnel")

// redeploy
execCmd(t, "kubectl", "apply", "-f", "deploy/kubernetes-deployment.yaml")
Expand Down

0 comments on commit 64f965e

Please sign in to comment.