Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify time span in max elevation tests #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjorgan
Copy link
Member

@bjorgan bjorgan commented Dec 28, 2017

Realized after commenting on #97 (comment) that there was something extremely fishy with the time span of the max elevation tests. Turned out that I by mistake had tested passes at 1, 3, 6, 10, 15, ..., 210 days from the TLE epoch, instead of 1, 2, ..., 20 days from the epoch. Prediction time for MOLNIYA and SIRIUS-1 increases linearly with the time from TLE epoch (see issue comment), so this led to larger test times.

Old running times for the tests:

      Start 23: maxelevation-sat_ERS-1_201509261800
23/32 Test #23: maxelevation-sat_ERS-1_201509261800 ..........   Passed    0.30 sec
      Start 24: maxelevation-sat_GPS_BIIA-10_201509261800
24/32 Test #24: maxelevation-sat_GPS_BIIA-10_201509261800 ....   Passed    0.49 sec
      Start 25: maxelevation-sat_HINODE_201509261800
25/32 Test #25: maxelevation-sat_HINODE_201509261800 .........   Passed    0.28 sec
      Start 26: maxelevation-sat_ISS_201509261800
26/32 Test #26: maxelevation-sat_ISS_201509261800 ............   Passed    0.28 sec
      Start 27: maxelevation-sat_MOLNIYA_1-29_201509261800
27/32 Test #27: maxelevation-sat_MOLNIYA_1-29_201509261800 ...   Passed   14.50 sec
      Start 28: maxelevation-sat_SIRIUS-1_201509261800
28/32 Test #28: maxelevation-sat_SIRIUS-1_201509261800 .......   Passed    6.36 sec
      Start 29: maxelevation-sat_THOR_III_201509261800
29/32 Test #29: maxelevation-sat_THOR_III_201509261800 .......   Passed    0.00 sec
      Start 30: maxelevation-sat_VELA-1_201509261800
30/32 Test #30: maxelevation-sat_VELA-1_201509261800 .........   Passed    0.51 sec

New running times for the tests after correction:

      Start 23: maxelevation-sat_ERS-1_201509261800
23/32 Test #23: maxelevation-sat_ERS-1_201509261800 ..........   Passed    0.29 sec
      Start 24: maxelevation-sat_GPS_BIIA-10_201509261800
24/32 Test #24: maxelevation-sat_GPS_BIIA-10_201509261800 ....   Passed    0.49 sec
      Start 25: maxelevation-sat_HINODE_201509261800
25/32 Test #25: maxelevation-sat_HINODE_201509261800 .........   Passed    0.29 sec
      Start 26: maxelevation-sat_ISS_201509261800
26/32 Test #26: maxelevation-sat_ISS_201509261800 ............   Passed    0.30 sec
      Start 27: maxelevation-sat_MOLNIYA_1-29_201509261800
27/32 Test #27: maxelevation-sat_MOLNIYA_1-29_201509261800 ...   Passed    2.45 sec
      Start 28: maxelevation-sat_SIRIUS-1_201509261800
28/32 Test #28: maxelevation-sat_SIRIUS-1_201509261800 .......   Passed    1.87 sec
      Start 29: maxelevation-sat_THOR_III_201509261800
29/32 Test #29: maxelevation-sat_THOR_III_201509261800 .......   Passed    0.00 sec
      Start 30: maxelevation-sat_VELA-1_201509261800
30/32 Test #30: maxelevation-sat_VELA-1_201509261800 .........   Passed    0.53 sec

Due to the other factors mentioned in #97 (comment), they still take 2.45 seconds at worst, but it is better than 14 seconds. :-)

…on tests. Led to test timepoints being more than 100 days since the TLE epoch, leading to long calculation times for some satellites.
@bjorgan bjorgan requested a review from ryeng January 27, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant