Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert custom component to external component #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert custom component to external component #3

wants to merge 1 commit into from

Conversation

syssi
Copy link

@syssi syssi commented May 9, 2022 •
edited
Loading

Closes: #2

73 de DO2KSM

@michaelpiron
Copy link

I support this pull request.
Besides the conversion from custom component to external, this commit solves a blocking problem:
In the current version of ESPHome (v2022.8.0), this custom component code fails to compile ('Nameable' was not declared in this scope).
This commit solves that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot compile. Nameable error
2 participants
@syssi @michaelpiron