Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a rascal json encoder from ase frames to a json readable by rascal (more important for the c++ side than python). Solves issue #363
TODO:
Tasks before review:
formatted correctly (ask @max-veit if you need help with this task).
explain the feature and its usage in plain English
to verify the fix and catch future regressions as well as similar bugs
elsewhere in the code.
make lint
on the project, ensure it passesmake pretty-cpp
andmake pretty-python
, check that theauto-formatting is sensible
own branch
nbstripout
Remaining tasks, out of scope of this pull request: (optional)
get forgotten!