Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rascal json encoder #366

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Rascal json encoder #366

wants to merge 3 commits into from

Conversation

agoscinski
Copy link
Contributor

Implements a rascal json encoder from ase frames to a json readable by rascal (more important for the c++ side than python). Solves issue #363

TODO:

  • add doc in the doc page how to use this
  • polish python doc of json_dumps_frame

Tasks before review:

  • Add tests, examples, and complete documentation of any added functionality
    • Make sure the autogenerated documentation appears in Sphinx and is
      formatted correctly (ask @max-veit if you need help with this task).
    • Write additional documentation in the Sphinx (not docstrings!) to
      explain the feature and its usage in plain English
    • Make sure the examples run (!) and produce the expected output
    • For bugfix pull requests, list here which tests have been added or re-enabled
      to verify the fix and catch future regressions as well as similar bugs
      elsewhere in the code.
  • Run make lint on the project, ensure it passes
    • Run make pretty-cpp and make pretty-python, check that the
      auto-formatting is sensible
    • Review variable names, make sure they're descriptive (ask a friend)
    • Review all TODOs, convert to issues wherever possible
    • Make sure draft, in-progress, and commented-out code is moved to its
      own branch
  • If committing any code in Jupyter/IPython notebooks, install and run nbstripout
  • Merge with master and resolve any conflicts
  • (anything else that's still in progress)

Remaining tasks, out of scope of this pull request: (optional)

  • Make sure to add these points to the issues or to the meeting agenda so they don't
    get forgotten!

@agoscinski agoscinski self-assigned this Jun 18, 2021
@agoscinski agoscinski linked an issue Jun 30, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rascal json encoder
1 participant