Issue347 dev #494
Open
Issue347 dev #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem reported on the issue was wrong, all works good, the text doesn´t seen well, but it has a scrollbar to solve the problem, but when i was testing that i saw that the component on the trackmanager were loking bad and this in the available layouts section too, so i fixed that. First, to the trackmaneger i put a line to the date or name to see text in a uniform way and separate the waypoints and trackpoints counter in two lines, this with the objetive of a friendly interface. Second, to the available layouts, i put a scroll bar and the same adjust to the text that i used in the track manager, to see text in a properly way.
Fixing padding in the buttons presets, because when the text is big, it no adjust in the correct way, and fixing the sizes of the dates or names on the track manager, this because the "uniform" prop that added, was causing the sizes were adjusting in different sizes each, so that look weird, so i put two possibles sizes for the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue mentioned in #347, where the problem was related to the size of the text when the largest text size setting is activated on the phone. Thanks to @miltonials, we confirmed that the problem mentioned in the PR was already solved with a scroll. However, during testing, we identified additional issues.
First problem
In the track manager the text for date, name, trackpoints and waypoints was to big for his container.
Example of the problem
How i solved it
How it looks now
Second problem
In the "Add Button Presets" section, when the available presets were displayed, the text didn’t fit within the button component.
Example of the problem
How i solved it
I increased the padding and margin of the buttons to provide more space.
I adjusted the text size to fit appropriately in all cases.
How it looks now
