refactor: size unit convert functions #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.38% (+0.12% 🔼) |
395/7342 |
| 🔴 | Branches | 4.67% (+0.14% 🔼) |
237/5077 |
| 🔴 | Functions | 3.22% (+0.08% 🔼) |
78/2420 |
| 🔴 | Lines | 5.29% (+0.12% 🔼) |
380/7182 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from f67ec31
Merge activity
|
Refactors binary and decimal size unit conversion functions This PR renames `iSizeToSize` to `convertBinarySizeUnit` and adds a new `convertDecimalSizeUnit` function to clearly distinguish between binary (1024-based) and decimal (1000-based) size unit conversions. The changes improve code readability and maintainability by: - Renaming `iSizeToSize` to the more descriptive `convertBinarySizeUnit` - Adding `convertDecimalSizeUnit` for 1000-based conversions - Introducing a shared internal `convertSizeUnit` function - Adding comprehensive unit tests for both conversion methods - Adding support for automatic unit selection with 'auto' parameter - Adding proper TypeScript exports for size unit types **Checklist:** - [ ] Test cases added to demonstrate binary vs decimal conversions - [ ] Unit tests verify correct handling of edge cases and automatic unit selection - [ ] All existing functionality maintained with renamed function
yomybaby
force-pushed
the
feature/refactor-convert-size-unit-functions
branch
from
3323020 to
f67ec31
Compare
graphite-app
bot
deleted the
feature/refactor-convert-size-unit-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors binary and decimal size unit conversion functions
This PR renames
iSizeToSizetoconvertBinarySizeUnitand adds a newconvertDecimalSizeUnitfunction to clearly distinguish between binary (1024-based) and decimal (1000-based) size unit conversions. The changes improve code readability and maintainability by:iSizeToSizeto the more descriptiveconvertBinarySizeUnitconvertDecimalSizeUnitfor 1000-based conversionsconvertSizeUnitfunctionChecklist: