fix(FR-5): Set accelerator value to 0 when no accelerator available #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.95% (-0.01% 🔻) |
398/8043 |
| 🔴 | Branches | 4.28% (+0.02% 🔼) |
239/5578 |
| 🔴 | Functions | 2.97% (-0% 🔻) |
78/2630 |
| 🔴 | Lines | 4.87% (-0.01% 🔻) |
383/7870 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / FormItemControl.tsx |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ResourceGroupSelect.tsx |
2.7% (-0.15% 🔻) |
0% | 0% | 2.78% (-0.16% 🔻) |
| 🔴 | ... / ResourceAllocationFormItems.tsx |
15.14% (-0.28% 🔻) |
10.45% (+0.12% 🔼) |
12.5% (-0.18% 🔻) |
14.88% (-0.28% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 9a2ea83
ironAiken2
requested changes
Jan 15, 2025
yomybaby
force-pushed
the
fix/accelerator-value-when-no-accelerator
branch
from
e1c55cd to
6fb80f0
Compare
|
Oh! Thank you. I jus pushed a changes. |
Merge activity
|
…3027) Resovles #2979 (FR-5) **Changes:** - Fixed accelerator slot handling in ResourceAllocationFormItems to properly handle undefined states - Improved accelerator input disable logic based on available slots and image requirements - Added optimistic updates to ResourceGroupSelect to improve UI responsiveness during transitions - Added new `FormItemControl` component to handle form item rendering with value and setValue callbacks (This component is not used yet) **Technical Details:** - Accelerator slots and image limits now properly handle undefined states during loading - Accelerator input is disabled when: - No accelerator slots are available - Selected image doesn't require accelerators and no manual environment is set - ResourceGroupSelect now shows optimistic updates during value transitions to prevent UI lag **Checklist:** - [ ] Please follow steps to reproduce in #2979 - [ ] Verify form behavior during resource group and image transitions - [ ] Check optimistic updates in resource group selection
ironAiken2
force-pushed
the
fix/accelerator-value-when-no-accelerator
branch
from
6fb80f0 to
9a2ea83
Compare
graphite-app
bot
deleted the
fix/accelerator-value-when-no-accelerator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resovles #2979 (FR-5)
Changes:
FormItemControlcomponent to handle form item rendering with value and setValue callbacks (This component is not used yet)Technical Details:
Checklist: