feature: make watchdog configuration more flexible #272
Conversation
✨ Amplify has finished checking this pull request👍 Everything looks good! No issues detected in 📄 2 files and ❇️ 17 lines of code. Security Pipeline
Last updated by commit 206af71 at 2024-09-18 23:42:04 UTC. Note To ignore a finding, append |
| modprobe: | ||
| name: softdog | ||
| name: "{{ pve_watchdog }}" |
There was a problem hiding this comment.
I'm kind of brooding over whether or not "just fallback to the value of pve_watchdog" is appropriate or not. The intel watchdog module is itco_wdt, which is a bit inconsistent with how pve_watchdog: ipmi loads ipmi_watchdog (i.e. not ipmi).
There was a problem hiding this comment.
Yeah, that it's part of the kernel_module_cleanup.yml is kind of dirty. It would look better to have separate tasks and import them depending on the pve_watchdog value.
There was a problem hiding this comment.
After thinking about it, I might (emphasis on might) eventually just replace/override the pve_watchdog role variable with a pve_watchdog_module role variable so that it's clearer that it's the module name and use that as the basis for making logical decisions about what configuration to create or clean up. Cause otherwise I'd've probably just wanted to have pve_watchdog: intel indicate configuring itco_wdt and whatever else.
Kernel module cleanup also does need to happen at a particular stage separate from configuration (iirc after/before kernel installation/upgrade) so it's a tricky line to tread. But we can work this out another day.
|
Sounds good. Thank you for merging |
resolves: #271