Skip to content

Commit

Permalink
Fixing docker image publish to ghcr (#4)
Browse files Browse the repository at this point in the history
  • Loading branch information
peter-mcclonski authored Nov 24, 2024
1 parent ff4316e commit 3e29484
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,4 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: build-and-push
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: make docker-buildx
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ docker-push: ## Push docker image with the manager.
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le
.PHONY: docker-buildx
docker-buildx: ## Build and push docker image for the manager for cross-platform support
docker login ghcr.io/lakekeeper ${GH_TOKEN}
# copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile
sed -e '1 s/\(^FROM\)/FROM --platform=\$$\{BUILDPLATFORM\}/; t' -e ' 1,// s//FROM --platform=\$$\{BUILDPLATFORM\}/' Dockerfile > Dockerfile.cross
- $(CONTAINER_TOOL) buildx create --name project-v3-builder
Expand Down

0 comments on commit 3e29484

Please sign in to comment.