-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(l1): reduce unnecessary docker builds and remove duplicate workflow executions in main #1032
Conversation
Unfortunately, I wasn't able to share the Docker image across workflows, the only way to depend on other workflows for the triggering condition is pushing them first to the default branch, which I wasn't really convinced and preferred to just make it work. The caveat? both hive and assertoor now share the same workflow, this makes the naming a bit longer; apart from that the Docker build is also run in the CI (to let the L2/EVM teams still leverage the build as part of their checks\merge queue) timing shouldn't be an issue due to both run at the same time. That said, we now removed 6 unnecessary builds from the run. |
Motivation
We are re-building our docker image across the jobs/workflows multiple times, the idea is to remove as much of the duplicate executions as possible. At the same time, while merging to main we run duplicated jobs, the idea is to remove that duplication.
Description
This PR accomplish a couple of things:
merge_group
andpush
rules were set)Resolves #1008
Resolves #1041