Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(l1): reduce unnecessary docker builds and remove duplicate workflow executions in main #1032

Merged
merged 22 commits into from
Oct 31, 2024

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Oct 31, 2024

Motivation

We are re-building our docker image across the jobs/workflows multiple times, the idea is to remove as much of the duplicate executions as possible. At the same time, while merging to main we run duplicated jobs, the idea is to remove that duplication.

Description

This PR accomplish a couple of things:

  • It creates a new make tasks for running hive without depending on the image build
  • It generates a new job in the hive workflow to build the image once and then share it with every simulation
  • Merges the assertoor stability check with hive to leverage the docker image already built
  • Fix an issue were workflows were triggered two times in a row while merging to main (both merge_group and push rules were set)

Resolves #1008
Resolves #1041

@rodrigo-o rodrigo-o changed the title Inter workflow artifact download test chore(l1): inter-workflow image download Oct 31, 2024
@rodrigo-o
Copy link
Collaborator Author

rodrigo-o commented Oct 31, 2024

Unfortunately, I wasn't able to share the Docker image across workflows, the only way to depend on other workflows for the triggering condition is pushing them first to the default branch, which I wasn't really convinced and preferred to just make it work. The caveat? both hive and assertoor now share the same workflow, this makes the naming a bit longer; apart from that the Docker build is also run in the CI (to let the L2/EVM teams still leverage the build as part of their checks\merge queue) timing shouldn't be an issue due to both run at the same time.

That said, we now removed 6 unnecessary builds from the run.

@rodrigo-o rodrigo-o changed the title chore(l1): inter-workflow image download chore(l1): reduce unnecessary docker builds and remove duplicate workflow executions in main Oct 31, 2024
@rodrigo-o rodrigo-o marked this pull request as ready for review October 31, 2024 20:15
@rodrigo-o rodrigo-o requested a review from a team as a code owner October 31, 2024 20:15
Makefile Show resolved Hide resolved
@rodrigo-o rodrigo-o added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit ce7eb98 Oct 31, 2024
14 checks passed
@rodrigo-o rodrigo-o deleted the reuse-docker-build-on-other-jobs branch October 31, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove workflow execution duplication when merging on main Reuse docker build in Hive jobs.
3 participants