Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(levm): ef test runner #1206

Merged
merged 22 commits into from
Nov 25, 2024
Merged

refactor(levm): ef test runner #1206

merged 22 commits into from
Nov 25, 2024

Conversation

ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Nov 19, 2024 •
edited
Loading

Description

  • Fixes EF tests parsing
  • Adds levm_runner module
  • Adds revm_runner module
  • Refactors runner module
  • Fixes post-state validations
  • Refactors report module.
  • Adds more reports.

@ilitteri ilitteri added ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation labels Nov 19, 2024
@ilitteri ilitteri self-assigned this Nov 19, 2024
@ilitteri ilitteri requested a review from a team as a code owner November 19, 2024 15:46
maximopalopoli
maximopalopoli previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@maximopalopoli maximopalopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after passing the CI

@ilitteri
Refactor runner
33b948f 
Now we have a levm_runner in charge of running the whole suite of tests (or the chosen ones) and then a revm_runner that re-runs the tests that levm failed to run successfully
@ilitteri
Isolate EF test parsing
950f2aa
@ilitteri
Fix initial state loading
9eaab48
@ilitteri
Fix types
cdc76d4
@ilitteri
Fix deserialization
e389c73
@ilitteri
Refactor report module
a28aa00
@ilitteri
Rename test file and modules
f72bd3f
@ilitteri
Ignore report file
798ca19
@ilitteri
Chore
0df3e41
@ilitteri
Merge main
1391e03
@ilitteri
Revert "Merge main"
3e7ece3 
This reverts commit 1391e03.
@ilitteri
Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…
50cf7af 
…to fix_ef_test_parsing
@ilitteri ilitteri changed the title fix(levm): do not skip VMTests in EF tests refactor(levm): ef test runner Nov 21, 2024
maximopalopoli
maximopalopoli approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@maximopalopoli maximopalopoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after passing the CI

JereSalo
JereSalo approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be very good if we could run tests with --nocapture for debugging purposes but I don't know if clap allows that.

@ilitteri
Fix
522ec08 
- Print and write report on internal errors
- Fix failed vector indexing error
@ilitteri
Improvements
15592c3
@ilitteri
Fix lint
0a904aa
@ilitteri
Merge branch 'main' of github.com:lambdaclass/ethrex into fix_ef_test…
4fc8b32 
…_parsing
@ilitteri ilitteri enabled auto-merge November 25, 2024 15:23
@ilitteri ilitteri added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 7f4e76f Nov 25, 2024
25 of 26 checks passed
@ilitteri ilitteri deleted the fix_ef_test_parsing branch November 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximopalopoli maximopalopoli maximopalopoli approved these changes

@JereSalo JereSalo JereSalo approved these changes

Assignees

@ilitteri ilitteri

Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilitteri @JereSalo @maximopalopoli