Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l1): snap sync #1209

Merged
merged 321 commits into from
Dec 10, 2024
Merged

feat(l1): snap sync #1209

merged 321 commits into from
Dec 10, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Nov 19, 2024 •
edited
Loading

Motivation
Support snap-sync

Description
Implements the snap-sync cycle with the following caveats:

  • No state healing is implemented (We asume all the state is available)
  • Storage ranges are fetched in full (We don't partition storage range requests, if an account's storage wasn't fully fetched as part of a batch it is requested again)
  • Minimum parallelization (We are currenltly testing against a single node so not all parallelizable processes are being parallelized.
  • Receipts are not fetched (waiting on GetReceipts (0x0f) #386)
  • State is not blocked during sync (this could lead to the wrong data being sent by rpc and p2p during an active sync)

Other changes:

  • Move crates/networking/p2p/README.rs to crates/networking/docs/Network.md
  • Add doc for Sync in crates/networking/docs/Sync
  • Reduce size of RLPxError

Closes #issue_number

fmoletta and others added 30 commits October 29, 2024 17:07
@fmoletta
Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…
65f8c77 
…to trie_iter
@fmoletta
Fix bug in response bytes length calculation
b7c0211
@fmoletta
Restore Makefile
74173d2
@fmoletta
Identify storage tries by hashed account address
777732a
@fmoletta
Merge branch 'trie_iter' into snap-storage-range
0e3e276
@fmoletta
Impl logic
abb28cf
@fmoletta
Connect to main loop
fea174d
@fmoletta
Compute proofs
dc6752c
@fmoletta
Clippy
03d9928
@fmoletta
Chamge type
c791a89
@fmoletta
Add test
9fd88d3
@fmoletta
Add messages
2b9d207
@fmoletta
Add hive test
37becaa
@fmoletta
fmt
a6d2f08
@fmoletta
Impl messages
c502f06
@fmoletta
Impl Trie::get_node
242502e
@fmoletta
Fix
3b7d70e
@fmoletta
Merge branch 'trie_iter' into snap-storage-range
384eff7
@fmoletta
Merge branch 'snap-storage-range' into snap-bytecodes
fa4be1b
@fmoletta
implement get_trie_nodes for storage
1cf1e9b
@fmoletta
Add byte limit
349d05f
@fmoletta
Add request processing
4fd0ee5
@fmoletta
Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…
d02e8f2 
…to snap-storage-range
@fmoletta
Merge branch 'snap-storage-range' of github.com:lambdaclass/lambda_et…
0575a44 
…hereum_rust into snap-storage-range
@fmoletta
Fix lingering conflicts
aa29e5f
@fmoletta
Save progress
89e144a
@fmoletta
Progress
1d8c3f9
@fmoletta
Progress
ea34fbc
@fmoletta
remove unused code
e57f386
@fmoletta
Handle wrong path input lens
0a31fc9
@fmoletta fmoletta changed the title [WIP] feat: snap sync feat: snap sync Dec 4, 2024
@fmoletta fmoletta changed the title feat: snap sync feat(l1): snap sync Dec 5, 2024
@fmoletta fmoletta marked this pull request as ready for review December 5, 2024 13:23
@fmoletta fmoletta requested a review from a team as a code owner December 5, 2024 13:23
mpaulucci
mpaulucci approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@fmoletta fmoletta enabled auto-merge December 10, 2024 13:49
@fmoletta fmoletta added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 88c6a8c Dec 10, 2024
15 checks passed
@fmoletta fmoletta deleted the snap-sync branch December 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmoletta @mpaulucci