feat(l2): prover comparison benchmarks #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchatruc
reviewed
Nov 27, 2024
crates/l2/prover/Makefile
Outdated
| > /dev/null 2>&1 | ||
| @echo "" | ||
| @echo "ethrex_l2 times (L2 block, 25 MGas):" | ||
| @RISC0_DEV_MODE=1 time $(ETHREX_L2_BIN) prove \ |
There was a problem hiding this comment.
Shouldn't this be RISC0_DEV_MODE=0?
There was a problem hiding this comment.
Yes! good catch, thanks!!
jrchatruc
approved these changes
Nov 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To compare the L2 prover performance with rsp.
Description
provecommand to the L2 CLI to prove a block from genesis and chain files