build(core): all-around tx check in assertoor #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
rodrigo-o
commented
Nov 25, 2024
rodrigo-o
commented
Nov 25, 2024
rodrigo-o
changed the title
rodrigo-o
commented
Nov 26, 2024
mpaulucci
reviewed
Nov 28, 2024
mpaulucci
approved these changes
Nov 28, 2024
rodrigo-o
commented
Nov 28, 2024
Comment on lines
+5
to
+9
| paths: | ||
| - 'README.md' | ||
| - 'LICENSE' | ||
| - "**/README.md" | ||
| - "**/docs/**" |
There was a problem hiding this comment.
This revert a change that spawned CI skipped checks on PRs that didn't need them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to have more checks regarding transactions, this PR accomplish that through assertoor
Description
This PR tackles 2 main things:
eoa-transactions-test[Link to playbook]To do it, I separated the
network_params.yamlused for themake localnetfrom 2 new ones used just for the assertoor workflow, one for the blobs + stability check and the other for the new tx checks.Also during the stability check we make sure at least one block is proposed by us with more than 50tx validating that the tx spammer is working as expected. The separation was done due to timing, it wasn't possible to parallelize the test as far as I checked without creating a new playbook and I preferred to use the already provided in parallel steps.
Apart from creating the 2 new files, I removed assertoor from the one used by
make localnet.TIME
Right now the new job takes ~15min, and added to the ~5min for the build it accounts to ~20min.
Closes #1128