feat(levm): running all ef tests with revm and fixing problems #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have a levm_runner in charge of running the whole suite of tests (or the chosen ones) and then a revm_runner that re-runs the tests that levm failed to run successfully
This reverts commit 1391e03.
…to fix_ef_test_parsing
…ambda_ethereum_rust into levm/running-ef-tests-revm
ilitteri
reviewed
Nov 27, 2024
cmd/ef_tests/levm/runner/mod.rs
Outdated
| @@ -55,6 +55,7 @@ pub fn run_ef_tests( | |||
| run_with_levm(&mut reports, &ef_tests)?; | |||
| } | |||
| re_run_with_revm(&mut reports, &ef_tests)?; | |||
| // _run_with_revm(&mut reports, &ef_tests)?; | |||
There was a problem hiding this comment.
If this is going to be merged to main we should remove this commented line and add documentation on the commented function explaining when to use it.
Suggested change
| // _run_with_revm(&mut reports, &ef_tests)?; |
ilitteri
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Runs all tests with revm -> Done
Fix execution of revm -> Most of Cancun tests have been fixed, 8 of them don't pass but it is good enough
Access lists are now deserialized, in .json files there are 1 access list per
dataelement. So we usedataindex for accessing them.I didn't make serious error handling for running with revm because it is not a core functionality, doing that will take a little bit more work but maybe it is not necessary.
Closes #issue_number