Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(l1): separate docker job and only build once. #1286

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

mpaulucci
Copy link
Collaborator

Reverts #1283

@mpaulucci mpaulucci requested a review from a team as a code owner November 26, 2024 18:24
@mpaulucci mpaulucci changed the title Revert "build(core): separate docker job and only build once." revert(l1): separate docker job and only build once. Nov 26, 2024
@mpaulucci mpaulucci added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit cbbb24b Nov 26, 2024
5 checks passed
@mpaulucci mpaulucci deleted the revert-1283-docker-job branch November 26, 2024 18:34
mpaulucci added a commit that referenced this pull request Nov 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2024
Reverts #1286

It turns out adding `workflow_run` for Hive and Assertor was working
after all (it took some time, wtf github actions). Do I re-added it.

Merge queue only runs when the PR is not synced with main, so it does
not work as a guarantee. Instead I moved most checks to be run as part
of `push`, to at least be able to pin point if something breaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants