fix(l1): remove "inconsistent internal tree structure" panics #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c2b46a.
xqft
changed the title
get() calls for pruned tries
xqft
changed the title
fkrause98
reviewed
Nov 28, 2024
| // it's potentially a new account. This is because we're using pruned tries | ||
| // so the path into a new account might not be included in the pruned state trie. | ||
| let mut account_state = match account_state { | ||
| Ok(Some(encoded_state)) => AccountState::decode(&encoded_state)?, |
There was a problem hiding this comment.
Can't we use "?" instead of matching with multiple Oks/Err?
There was a problem hiding this comment.
We can't because we want to match the InconsistentTree error and interpret it as a "state not found" error instead of propagating it
fmoletta
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
Trielibrary assumes that all tries are well-formed: this means that if some node contains the hash of a child, then that child is in the tire's database. If this doesn't hold, then aget()call panics with aninconsistent internal tree structuremessage.For the L2 prover we're using "pruned tries" which only store the relevant nodes for the set of values touched in some execution, breaking the previous hypothesis. One option was to capture the panics on the get calls, but this wasn't safe because
Triehas internal mutability. The path chosen is to remove the panics altogether and replace them with errors.Description