Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l1): add transactions to the mempool when receiving them via p2p #1304

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Nov 27, 2024

Closes #1129

@Arkenan Arkenan marked this pull request as ready for review November 27, 2024 16:52
@Arkenan Arkenan requested a review from a team as a code owner November 27, 2024 16:52
txs_msg @ Message::Transactions(_) if peer_supports_eth => {
self.broadcast_message(txs_msg).await?;
Message::Transactions(txs) if peer_supports_eth => {
for tx in &txs.transactions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Arkenan Arkenan enabled auto-merge November 28, 2024 15:34
@Arkenan Arkenan added this pull request to the merge queue Nov 28, 2024
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Merged via the queue into main with commit 94b36b5 Nov 28, 2024
12 checks passed
@Arkenan Arkenan deleted the add-tx-mempool branch November 28, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L1: Add transactions to mempool when they're received from a P2P message.
3 participants