ci(core): standarize all CIs with required checks #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ci-cleanup-hive
…to ci-cleanup-hive
mpaulucci
changed the title
mpaulucci
changed the title
rodrigo-o
approved these changes
Nov 28, 2024
| - name: Run Hive Simulation | ||
| run: ${{ matrix.run_command }} | ||
| run: cd hive && ./hive --client ethrex --sim ${{ matrix.simulation }} --sim.parallelism 4 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Required checks in Github works in a weird way, it is based on the job name. So we will define a couple of required checks:
Each team will have one or more workflow, prepended with "ci_". There they need to define all the above jobs. If there are multiple jobs with the same name, they are all required.
For the merge queue, we keep it minimal and aim only to avoid breaking changes that should be caught by the Rust compiler or linter. We don't want to run heavy integration tests since those will be run on the push event anyway.
Description