fix(levm): modify transfer timing #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was made when fixing a test, in which the target account and the current account were the same. The target, when modified after the current account but accessed before the modification, was not taking the change into account.
maximopalopoli
changed the title
maximopalopoli
changed the title
maximopalopoli
changed the title
ilitteri
reviewed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously the value was added to receiver a subbed to sender twice with a delegatecall operation, this PR fixes it. Also, the transfer of the value was done when the transaction was confirmed, disallowing self recursive contracts.
Description
This is done by using a should_transfer_value flag, that performs the value transfer when it is activated, and transferring before the execute and reverting if result is revert.