chore(l2): trying to implement no_panic crate #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
force-pushed
the
l2/no_panic_crate
branch
from
2dce319 to
b9d01a9
Compare
fborello-lambda
changed the title
jrchatruc
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As explained by issue #1369, implementing the
no_paniccrate would help prevent some hidden panics.Description
I've tried to implement it for the non-async functions, facing the following problems:
For functions interacting with
TcpStreamand theDatabaseit throws a "panic compilation error".The
keccakfunction used andc-kzgthrows the "panic compilation error".no_panicseems to be a crate that aims to avoid panics in low level lib crates.Found a potential panic in
fake_exponential, it's solved by thefake_exponential_checkedimplementation.Some extra changes regarding usability were added.
Remove
pubkeyword if not needed.See if we can close the issue #1369