Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(levm): disable spinner tests #1396

Merged
merged 7 commits into from
Dec 3, 2024
Merged

feat(levm): disable spinner tests #1396

merged 7 commits into from
Dec 3, 2024

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Dec 3, 2024 •
edited
Loading

Motivation

  • When running EFTests in CI the spinner is very annoying and it makes it hard to observe the output. The objective is to make the EFTests more suitable for the CI so that we can use that as a tool for checking when something stopped working (or simply tracking progress)

Description

  • Implements flag disable-spinner, if set, the main spinners will stop and it will replace the "spinner prints" for println!
  • Fixes index error in REVM

Closes #issue_number

@JereSalo JereSalo added the levm Lambda EVM implementation label Dec 3, 2024
@JereSalo JereSalo self-assigned this Dec 3, 2024
@JereSalo JereSalo marked this pull request as ready for review December 3, 2024 20:03
@JereSalo JereSalo requested a review from a team as a code owner December 3, 2024 20:03
@JereSalo JereSalo merged commit bcdbf6d into levm/skip-slow-tests Dec 3, 2024
4 checks passed
@JereSalo JereSalo deleted the levm/disable-spinner-tests branch December 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JereSalo JereSalo

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JereSalo