Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(levm): organize callframe #1501

Merged
merged 9 commits into from
Dec 16, 2024
Merged

refactor(levm): organize callframe #1501

merged 9 commits into from
Dec 16, 2024

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Dec 13, 2024 •
edited
Loading

Motivation

  • remove unnecessary stuff and make things clearer

Description

  • Adds comments to CallFrame
  • Changes returndata name for output, because it had that role and it was confusing when comparing with Exec specs.
  • Remove sub_return_data_offset and sub_return_data_size because from CallFrame they were unnecessary

Closes #issue_number

@JereSalo JereSalo added the levm Lambda EVM implementation label Dec 13, 2024
@JereSalo JereSalo self-assigned this Dec 13, 2024
@JereSalo JereSalo marked this pull request as ready for review December 13, 2024 13:30
@JereSalo JereSalo requested a review from a team as a code owner December 13, 2024 13:30
LeanSerra
LeanSerra approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

damiramirez
damiramirez approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@damiramirez damiramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JereSalo JereSalo enabled auto-merge December 16, 2024 13:04
@JereSalo JereSalo added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit be73e39 Dec 16, 2024
8 checks passed
@JereSalo JereSalo deleted the levm/organize_callframe branch December 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

@damiramirez damiramirez damiramirez approved these changes

@LeanSerra LeanSerra LeanSerra approved these changes

Assignees

@JereSalo JereSalo

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JereSalo @LeanSerra @damiramirez @ilitteri