Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(levm): implement precompile ripemd160 #1521

Merged
merged 56 commits into from
Dec 18, 2024
Merged

feat(levm): implement precompile ripemd160 #1521

merged 56 commits into from
Dec 18, 2024

Conversation

maximopalopoli
Copy link
Contributor

Motivation

The goal is to implement ripemd160 precompile.

Description

The implementation is quite similar to the sha2-256. There is one test named static_Call50000_rip160 that fails, but I think that fails due to other reasons.

ilitteri and others added 30 commits December 10, 2024 13:07
@ilitteri
Add precompiles scaffolding
98d399a
@ilitteri
Add precompiles scaffolding
9162091
@ilitteri
Merge branch 'precompiles_support_scaffolding' of github.com:lambdacl…
4be01c9 
…ass/ethrex into precompiles_support_scaffolding
@maximopalopoli
Merge branch 'main' into precompiles_support_scaffolding
9d1f658
@maximopalopoli
Add precompile error to VMError
6d422c4
@maximopalopoli
Change precompile functions parameters
6fd6c5c
@maximopalopoli
Add precompile handling in VM::execute
ec8ab4d
@maximopalopoli
Return VMError instead of InternalError
47b1192
@maximopalopoli
Fix tests
ba1407d 
The tests were not passing because the addresses assigned for the
 contracts were the reserved for the precompiles
@maximopalopoli
Fix clippy
dc45403
@maximopalopoli
Make the precompile sub-functions return a VMError
7ea3c41
@maximopalopoli
Revert changes in precompiles.rs since it's a call
f920a66
@maximopalopoli
Make the output of the precompile the output of tx
6664d54
@maximopalopoli
Merge branch 'main' into precompiles_support_scaffolding
290de6c
@maximopalopoli
Initital implementation of ecrecover
229673d
@maximopalopoli
Add libsecp256k1 dependency
11adaa8
@maximopalopoli
Add keyRecoverError
e36e69a
@maximopalopoli
Implement recover call and improve initial parsing
db3af34
@maximopalopoli
Merge branch 'main' into levm/feat/impl-precompile-ecrecover
532f214
@maximopalopoli
make ecrecover to not panic, use extend_from_slice
6e9be8b
@maximopalopoli
Fix output slicing
970cca0
@maximopalopoli
Add check for gas limit
1372592
@maximopalopoli
Add zeros at end of calldata if necessary
5def41a
@maximopalopoli
Add unit test
a2968d2
@maximopalopoli
fix clippy+fmt
5d759d3
@maximopalopoli
consume gas before and match recover result
350b57b
@maximopalopoli
match RecoveryId result
927131e
@maximopalopoli
Merge branch 'main' into levm/feat/impl-precompile-ecrecover
0b0f306
@maximopalopoli
delete loc_report.txt file
fa664a9
@maximopalopoli
Move forward the gas limit - gas consumed check
40e4a00
@maximopalopoli maximopalopoli self-assigned this Dec 17, 2024
@maximopalopoli maximopalopoli added the levm Lambda EVM implementation label Dec 17, 2024
@maximopalopoli maximopalopoli marked this pull request as ready for review December 17, 2024 16:36
@maximopalopoli maximopalopoli requested a review from a team as a code owner December 17, 2024 16:36
LeanSerra
LeanSerra approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the precompiles are starting to look really clean. It would be nice if you added some simple unit tests, just the example from evm.codes would be enough. Just a suggestion.

JereSalo
JereSalo requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@JereSalo JereSalo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good but can you add a simple unit test checking that the gas and output of the function are correct?
Using evm.codes examples for each precompile would be great!

edit: oh, Lean said the same haha

Base automatically changed from levm/feat/impl-precompile-sha2-256 to main December 18, 2024 14:28
@JereSalo JereSalo enabled auto-merge December 18, 2024 21:47
@JereSalo JereSalo added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 4b7c965 Dec 18, 2024
16 checks passed
@JereSalo JereSalo deleted the levm/feat/impl-precompile-ripemd160 branch December 18, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JereSalo JereSalo JereSalo approved these changes

@LeanSerra LeanSerra LeanSerra approved these changes

Assignees

@maximopalopoli maximopalopoli

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximopalopoli @LeanSerra @JereSalo @ilitteri