fix(levm): create to an existing address #1523
Conversation
… transact(). Revert in this case.
damiramirez
changed the title
| // transaction should be reverted. | ||
| if self.is_create() { | ||
| let new_address_acc = self.db.get_account_info(initial_call_frame.to); | ||
| if new_address_acc.has_code() || new_address_acc.has_nonce() { |
There was a problem hiding this comment.
Question: Should this be an || or a &&?
If an || is needed, then I think a function already exists for it
| if new_address_acc.has_code() || new_address_acc.has_nonce() { | |
| if new_address_acc.has_code_or_nonce() { |
Having said that, I think the function itself is a bit overkill.
There was a problem hiding this comment.
It is an ||. We created the function because of the specs. It may be a little bit overkill but we can use it I guess.
There was a problem hiding this comment.
The type of new_address_acc is AccountInfo. This type doesn't have that method :( Maybe we can implement it in the future.
There was a problem hiding this comment.
It is an
||. We created the function because of the specs. It may be a little bit overkill but we can use it I guess.
Noted, thank you for the link Jere!
The type of
new_address_accisAccountInfo. This type doesn't have that method :( Maybe we can implement it in the future.
Oh, my mistake Dami.
Co-authored-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
| .checked_add(new_account.balance) | ||
| .ok_or(VMError::BalanceOverflow)?; | ||
|
|
||
| if !new_account.has_code() && !new_account.has_nonce() { |
There was a problem hiding this comment.
| if !new_account.has_code() && !new_account.has_nonce() { | |
| if !new_account.has_code_or_nonce() { |
Thank you De Morgan (?)
There was a problem hiding this comment.
It's not necessary to change it. Maybe it is more readable the original way haha
There was a problem hiding this comment.
Yes hahaha I think the first implementation is more readable.
Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
Motivation
The
CREATEtransaction logic did not handle the case where the address where we the contract will be deploy already exists.Description
VM::new()where the transaction isCREATE. Ifnew_contract_addressexists in the db and it has nonce or bytecode, we don't create the new account and we don't add it in the cache. We know this is an error and the revert will be handled intransact()transact(), we check if the transaction isCREATEand ifnew_address_acchas code or nonce. In that case we return aTransactionReportwithTxResult::Revert.Related #1517