feat(l1) add receipt fetching to snap [waiting for bases to be merged] #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation** This PR aims to implement the ecrecover precompile. **Description** There are some cases where returning an empty set of bytes makes more tests pass than returning an error. In those cases I left the match. --------- Co-authored-by: ilitteri <ilitteri@fi.uba.ar> Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
**Motivation**
- The `code_deposit_cost` was deducted outside of the callframe that
does the contract creation for CREATE type transactions, this was
incorrect because subtracting `code_deposit_cost` could make the
callfreme revert because of OOG
**Description**
- Unify the contract creation behaviour between the opcodes
CREATE/CREATE2 and transactions of type CREATE.
- After the callframe that does contract creation succeeds do the
following checks:
- Check if the output of this callframe is valid contract (verify length
&& first byte != 0xef")
- Check if the `current_callframe.gas_used + code_deposit_cost <
current_call_frame.gas_limit`
If any of this checks fail revert the callframe
If the checks pass add the bytecode to the new account address
- Remove the `create_post_execution` function as the functionality is
now done at return in callframe execution
**Motivation** The goal is to implement the sha2 256 precompile. **Description** For this precompile I struggled to add unit tests, but the EF tests related to sha2 256 precompile are passing. --------- Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
We should touch precompiles from 1 to 10, including the last one. Changes the exclusive range for an inclusive one.
#1527) **Motivation** The account was not removed when calling selfdestruct in CREATE type transactions because the new account was not in the accrued_substate **Description** - Add the new address to the substate at vm creation time.
…to eth-get-receipts-msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1432 + #1505
Motivation
Fetch receipts for blocks before the pivot during snap sync
Description
request_receiptsmethod toPeerChannelsCloses #issue_number